[EXTDAM-138] Improve S3 rendering Created: 28/Aug/20  Updated: 14/Oct/20  Resolved: 13/Oct/20

Status: Closed
Project: External DAMs
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.2

Type: Improvement Priority: Neutral
Reporter: Laura Delnevo Assignee: Jesus Alonso
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: 1.5h
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: DAM Phase 2
Sprint: Add-Ons 47, Add-Ons 48
Story Points: 5

 Description   

In S3 external dam we have an issue displaying the asset tree for the first time. When there are many buckets, it takes a very long time to render the tree for the first time. Then the assets are cached and we don’t have this issue anymore. Also opening other folders has no problem.

The main issue is vaadin needs to know whether each folder has children or not. To do so, vaadin calls sequentially the hasChildren method in the corresponding HierarchicalDataProvider for the view. This is always translated into a remote API call. Thus, in case of having several buckets, rendering the tree when is not cached could take a long time.

Solution

  • Verify whether a bucket has children or not within the getAllBuckets method. We do this in parallel instead of sequentially
  • Override HierarchicalS3DataProvider.hasChildren to use this new property when available.

Notice it was not possible to override hasChildren, as it was never used. See MGNLUI-6229 for more details.

 


Generated at Mon Feb 12 01:52:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.