[EXTDAM-58] (S3) Should not throw NPE when deselect item after renaming asset Created: 06/Feb/20  Updated: 10/Mar/20  Resolved: 10/Mar/20

Status: Closed
Project: External DAMs
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Bug Priority: Neutral
Reporter: Yen Lac Tue Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2.65h
Original Estimate: Not Specified

Attachments: Text File s3_after_rename_error.txt     PNG File s3_error_after_rename.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: DAMs backend
Sprint: Add-Ons 32, Add-Ons 33
Story Points: 5

 Description   

Step to reproduce:

  • Select s3 item, click "Rename asset"
  • After rename successfully, click to deselect that item then system show exception

Refer attached error log file for more information. s3_after_rename_error.txt

Caused by: java.lang.NullPointerExceptionCaused by: java.lang.NullPointerException at info.magnolia.external.dam.s3.app.HierarchicalS3DataProvider.getId(HierarchicalS3DataProvider.java:41) ~[magnolia-external-dam-s3-1.0-SNAPSHOT.jar:?] at info.magnolia.external.dam.s3.app.HierarchicalS3DataProvider.getId(HierarchicalS3DataProvider.java:32) ~[magnolia-external-dam-s3-1.0-SNAPSHOT.jar:?]

 



 Comments   
Comment by Roman Kovařík [ 03/Mar/20 ]

I've looked into this issue again and it looks more severe than expected.

All problems comes from the fact that

This goes even beyond Vaadin issues

E.g. In JCR impl the items are referenced by their UUIDs which is still the same after move operation.

There is a possibility to workaround this issue by making mentioned places null safe in S3 impl (data communicator, selection model, data provider, item provider...) but I'd suggest to consider the importance of the rename operation. According to the impl it's not even supported by amazon and is done by combination of copy/delete operation, so we might think of doing the same.

Generated at Mon Feb 12 01:51:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.