[FORMDB-8] Remove dependency on STK Created: 24/Jun/15  Updated: 07/Sep/15  Resolved: 07/Sep/15

Status: Closed
Project: Form2DB App
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Edgar Vonk Assignee: Marvin Kerkhoff
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Java Source File Form2dbProcessor.java     XML File pom.xml    
Issue Links:
Relates
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

With Magnolia 5.4 and the STK being effectively deprecated I think the form2db module should also remove its dependency on the STK like other Magnolia modules have done. Also see: SUPPORT-4727

The dependency is at least in the module descriptor. Not so such if the form2db module actually uses the STK at all?



 Comments   
Comment by Edgar Vonk [ 14/Aug/15 ]

Hi Marvin. Any news on this issue at all? We really want to move away from the STK (in Magnolia 5.4) and currently cannot use your nice form2db module because of its dependency with the STK. It would be great to get rid of this dependency. Let us know if we can help you with this! With the move to Stash it should be a lot easier for us to create forks/branches for stuff like this.

Comment by Marvin Kerkhoff [ 17/Aug/15 ]

Hi Edgar,

actually no good news about migrating the module to 5.4

Thanks for your help
Marvin

Comment by Edgar Vonk [ 18/Aug/15 ]

Maybe we could help if that's ok with you? Looking at the source code this is very easy. The old STK FormProcessor classes have simply been moved to the Magnolia Forms Module now. That's all there is to it. I have done the following to get this working:

  • in the pom.xml replace
    <dependency>
    	  <groupId>info.magnolia</groupId>
    	  <artifactId>magnolia-module-standard-templating-kit</artifactId>
    	  <version>${magnoliaSTKVersion}</version>
    	</dependency>

    by:

        <groupId>info.magnolia</groupId>
          <artifactId>magnolia-module-form</artifactId>
          <version>${magnoliaFormVersion}</version>
        </dependency>
  • and:
    <magnoliaSTKVersion>2.8</magnoliaSTKVersion>

    by:

        <magnoliaFormVersion>2.3</magnoliaFormVersion>
  • also changed:
    <magnoliaVersion>5.3</magnoliaVersion>

    to:

    <magnoliaVersion>5.4</magnoliaVersion>
  • recompiled and fixed imports in the Form2dbProcessor class so that it now uses the forms module

That's it.

I now Magnolia is moving to Stash which will make forks and pull requests such as this much easier

Comment by Marvin Kerkhoff [ 18/Aug/15 ]

The movement to stash is nice. We waiting so long for this. If you want you can send me a pull request, otherwise i will have a look if i can update the module at the evening. Hopefully my Win10 Update will work X-D

Comment by Edgar Vonk [ 18/Aug/15 ]

I would love to send you a pull request but to be honest I have no idea how. Do you mean using Stash? Is the form2db code already in Stash? When I log in to https://scm.magnolia-cms.com/ I only see the MAGNOLIA (main) project.

Comment by Edgar Vonk [ 18/Aug/15 ]

I have attached the pom.xml and Form2dbProcessor.java files that I changed to fix this issue.

Comment by Edgar Vonk [ 27/Aug/15 ]

Hi Marvin, any updates on this at all? We are moving to Magnolia 5.4 (without STK) and would like to keep on using your module.

Comment by Marvin Kerkhoff [ 05/Sep/15 ]

Hi Edgar,

i also updated the module descriptor. Please have a look at my new version 1.1.0 which should be compatible with 5.4. I highly recommend to update your 5.3 instances to version 1.0.8. I fixed a bug with attachments in the form processor.
If you can test it and give me a feedback if everything is working fine, would be great. Actualy i didn't spend much time on testing.

Thanks for your help,
Marvin

P.S. If you have suggestions to make the interface of the app more usable i would like to hear that, too.

Comment by Edgar Vonk [ 06/Sep/15 ]

Thanks @marvink2! It's working nicely now in our 5.4 implementation.

Only thing what would be nice is if you could deploy (in future?) the source code jar to Magnolia's Nexus next to the jar itself. That would make debugging etc much easier for us. Pretty much all other Magnolia modules do have this. I guess a small change in your release procedure would fix this.

Concerning the interface of the app, yes I think we might have some suggestions. I think @mchruscielewski has some ideas?

Comment by Edgar Vonk [ 06/Sep/15 ]

You may close this issue now.

Generated at Mon Feb 12 01:58:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.