[FREEZE-1] Refactor rest endpoint configuration Created: 24/Oct/18  Updated: 31/Jan/19  Resolved: 29/Oct/18

Status: Closed
Project: Freeze
Component/s: None
Affects Version/s: 1.3
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Richard Gange Assignee: Andrew Warinner
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bootstraps.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

To do:

  • Remove the bootstraps
    • Do not bootstrap onto rest services module
  • Create yaml-based rest endpoint configuration
    • Be sure to use the new restEndpoints registry in a light module


 Comments   
Comment by Richard Gange [ 29/Oct/18 ]

I tried to rearrange this but hit a dead end. Apparently you cannot use the same implementation class twice:

2018-10-29 16:22:08,707 INFO  info.magnolia.module.ModuleManagerImpl            : Starting module rest-integration
2018-10-29 16:22:08,857 INFO  ource.yaml.AbstractFileResourceConfigurationSource: Setting up YamlConfigurationSource to load EndpointDefinition definitions from resources
2018-10-29 16:22:09,135 INFO  agnolia.config.source.yaml.YamlConfigurationSource: Registered definition from YAML file [/freeze/restEndpoints/freezeCommands.yaml]: [restEndpoint] definition [freezeCommands] with reference id: [freezeCommands] from module [freeze] at [freezeCommands]
2018-10-29 16:22:09,137 WARN  agnolia.config.source.yaml.YamlConfigurationSource: 1 major and 0 minor problems have been encountered
2018-10-29 16:22:09,138 WARN  agnolia.config.source.yaml.YamlConfigurationSource: 
Severity type:   MAJOR 
Title:           /freeze/restEndpoints/freezeCommands.yaml: [Definition semantics] - Conflict endpoint definitions. 
Problem details: Endpoint definitions [freezeCommands:freezeCommands] and [commands:commands] both declare implementationClass [class info.magnolia.rest.service.command.v2.CommandEndpoint]. REST module V1 does not support endpoints with identical implementationClass. 
Generated at Mon Feb 12 02:03:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.