[FREEZE-5] Should not use samples for important configuration Created: 09/Apr/19 Updated: 04/May/22 Resolved: 08/Jul/20 |
|
| Status: | Closed |
| Project: | Freeze |
| Component/s: | None |
| Affects Version/s: | 1.6.1 |
| Fix Version/s: | 1.8 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Joerg von Frantzius | Assignee: | Andrew Warinner |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Description |
|
Currently important bootstrap configuration is placed in https://git.magnolia-cms.com/projects/SERVICES/repos/freeze/browse/src/main/resources/mgnl-bootstrap-samples/freeze . This configuration overrides publishing-core config in order to prevent publication and unpublication from happening during freeze e.g. when a workitem was approved. This means that the above happens only when magnolia.bootstrap.samples=true in the magnolia properties. This is usually not the case in production setups, and also it creates confusion when some functionality is working depending on samples being bootstrapped or not (samples usually are for example content, not required configuration). Additionally, we'd like to modify this configuration, and now we need to distinguish in our ModuleVersionHandler whether samples are bootstrapped or not. These files should be placed in https://git.magnolia-cms.com/projects/SERVICES/repos/freeze/browse/src/main/resources/mgnl-bootstrap/freeze instead, just like the other config bootstrap there? |