[GOOGLE2FA-1] Change Name? Created: 08/Jan/24 Updated: 10/Jan/24 |
|
| Status: | Open |
| Project: | google-2fa-authenticator |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Spike | Priority: | Neutral |
| Reporter: | Chris Jennings | Assignee: | Le Hai Thanh |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Date of First Response: |
| Description |
|
This module makes use of an open standard, RFC 6238, TOTP: Time-Based One-Time Password Algorithm. The secret key and corresponding QR code is generated inside Magnolia and the checking is handled by Magnolia. No Google services are used. Google Authenticator is a popular mobile app for generating one time codes from a private key but many alternatives are available. By naming Google in the module, do we imply there is a dependency on a proprietary service and could this put people off? |
| Comments |
| Comment by Le Hai Thanh [ 09/Jan/24 ] |
|
Hi chris.jennings , Thank you for your input! The initial requirement originated from our potential client, necessitating a Google Authenticator integration, hence the module's name. The module was completed three years ago, and even after migrating to the incubator repo, I retained the same name. It would be fantastic to refactor the module and make it more generic. Any suggestions or contributions would be greatly appreciated Thanks, Thanh Le
|
| Comment by Chris Jennings [ 09/Jan/24 ] |
|
That's great. I'm glad you think it could be a good idea. If we start again from v1.0 we could do some more refactoring like dropping the bootstrapped module config for more decorators too. |
| Comment by Le Hai Thanh [ 10/Jan/24 ] |
|
Hi tmiyar , What are your thoughts on refactoring the module's name? If feasible, would we release a new incubator module and archive the current one? I'm asking because I'm not well-versed in the incubator process. Thank you for your advice. Thanh Le |
| Comment by Teresa Miyar [ 10/Jan/24 ] |
|
thanh.lehai I think it would make sense to duplicate the module and deprecate this one. |