[LIVECOPY-230] [Investigation] Live Copy performance tuning Created: 29/Oct/20  Updated: 16/Jul/21  Resolved: 01/Jul/21

Status: Closed
Project: Live Copy
Component/s: None
Affects Version/s: None
Fix Version/s: 3.2.4

Type: Task Priority: Medium
Reporter: Laura Delnevo Assignee: Chuong Doan Huy
Resolution: Fixed Votes: 0
Labels: VN-Analysis, VN-Maintenance, VN-Testing, maintenance
Remaining Estimate: 0d
Time Spent: 6d 0.5h
Original Estimate: Not Specified

Attachments: PNG File image-2021-06-02-08-13-20-186.png    
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: Live Copy maintenance
Sprint: Content Mngmt 6, Content Mngmt 7
Story Points: 8

 Description   

Use case - push and relink functionality on 5.7

  • Belimo is working with live copy since the beginning. He has now 23 live copy trees. The push and relink get’s slower and slower.
  • On 5.7, first everything will be pushed and after that it goes through everything and relinks it. I guess what could be a significant performance boost is if the relink would be triggered with the push of the data. It just requires that all pages which are newly created are already in place. The Customer already mentioned that it takes minutes to push something, so it’s already noticed.

Investigation

  • What causes the system to slow down: push and relink, others  
  • What can be done to improve the performance 
  • Should we use Elastic Search together with LC: there are a lot of queries by id, that I think might be the cause of the slowness


 Comments   
Comment by Marvin Kerkhoff [ 02/Jun/21 ]

We have found one bigger performance issue in the Class https://git.magnolia-cms.com/projects/ADDON/repos/live-copy/browse/src/main/java/info/magnolia/livecopy/command/PropagateMasterContentChangesCommand.java#125

This method collects all children and then does the same in the for loop. The result is a massive collection with endless duplicates.

Comment by Chuong Doan Huy [ 30/Jun/21 ]

In 5.7, "push" and "relink" are separated actions, so the "push trigger relink" is not possible unless ui/feature change required. ==> No action on LC for 5.7
However from 6.2, in "push" action, "relink" is included as an option, so a performance boot can be expected. The real performance issue came from "executeRecursively" method pointed by Marvin ==> Fix on 6.2

Generated at Mon Feb 12 02:26:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.