[LIVECOPY-232] Creating livecopy if parent or some of child page is locked throws error Created: 24/Nov/20  Updated: 06/Jan/21  Resolved: 06/Jan/21

Status: Closed
Project: Live Copy
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Evzen Fochr Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: Ext DAMs maintenance & partnership support

 Description   

Steps to reproduce

  1.  Try to create livecopy form locked node (f.e. by ab testing)
  2.  Same if child node si locked

Logs, screenshots, gifs...

Expected results

livecopy is created withour error

Justify non-trivial expectations with a link to a doc or a relevant discussion.

Actual results

error while setting MASTER_CONTENT property because of lock
livecopy is created but miss parrent

Workaround

unlock node by removing variant from ab test etc.

Development notes

We will probably need to check if note is locked and temporarily unlock it
info.magnolia.livecopy.command.CreateLiveCopyCommand#markAsMasterNode
but as this locking is part of ab testing info.magnolia.abtesting.locking.ContentLockingManager
I would suggest to disable create LC action for locked node (check for node.isLocked()) and to filter out locked children from recursion.
These children can be synchronized later by propagate master content change action.



 Comments   
Comment by Evzen Fochr [ 06/Jan/21 ]

Closing this ticket as "won't do" because we removed locking mechanism from abtesting cc ldelnevo

Generated at Mon Feb 12 02:26:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.