[LIVECOPY-266] Impact defaultLocale on Authoring support Created: 16/Jun/21  Updated: 19/Aug/21  Resolved: 18/Aug/21

Status: Closed
Project: Live Copy
Component/s: None
Affects Version/s: 3.2.3
Fix Version/s: 3.2.6

Type: Bug Priority: Neutral
Reporter: Tobias Kerschbaum Assignee: Nguyen Phung Chi
Resolution: Fixed Votes: 1
Labels: VN-Implementation, VN-Maintenance, cm-team-support, maintenance
Remaining Estimate: 0d
Time Spent: 2d 7.5h
Original Estimate: Not Specified

Attachments: File config.modules.multisite.config.sites.pageA.yaml     File config.modules.multisite.config.sites.pageB.yaml     XML File website.xml     PNG File withDefaultLocaleAuthoringSupport.png     PNG File withoutDefaultLocaleAuthoringSupport.png    
Issue Links:
Relates
relates to LIVECOPY-262 Test Only - MasterLocale not part of ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Live Copy maintenance
Sprint: Content Mngmt 10
Story Points: 5

 Description   

Steps to reproduce

  1. Import Site configuration and website workspace as attached
  2. Open the pages app of pageB
  3. Delete the defaultLocale of the site config of siteB
  4. open the pages app of pageB again 

Expected results

I would expect that the default locale has no impact on the language switch in the pages app. Because pageB has nl as fallback language, I would expect to see Dutch preselected.

Actual results

With defaultLocale:

 

Without defaultLocale:

Workaround

Development notes

Our Partner Dev5310 suggested a fix in the Ticket https://jira.magnolia-cms.com/browse/SUPPORT-13188

In my opinion this is not really working because without setting the defaultLocale you still get German preselected.

 

I tried to fix it by my own but i am not sure if this breaks something else. If we would change -> Class → info.magnolia.livecopy.i18n.LiveCopyI18nContentSupport (Line 89 - 92)

@Override
public Locale getFallbackLocale() {
    return masterLocale != null ? new Locale(masterLocale) : super.getFallbackLocale();
}

// INTO

@Override
public Locale getFallbackLocale() {
    return super.getFallbackLocale() != null ? super.getFallbackLocale() : new Locale(masterLocale);
}

The problem is gone without the need to set the defaultLocale.



 Comments   
Comment by Fabian Bading [ 16/Jun/21 ]

This bug is an issue for our go-live of the new Aurubis Page.

Generated at Mon Feb 12 02:27:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.