[LIVECOPY-325] Null pointer for non-internationalized sites Created: 13/Jul/22 Updated: 26/Aug/22 |
|
| Status: | Open |
| Project: | Live Copy |
| Component/s: | None |
| Affects Version/s: | 3.2.8 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Low |
| Reporter: | Richard Gange | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: | |
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Epic Link: | AuthorX Maintenance |
| Team: |
| Description |
|
When trying to push changes to a site which is not internationalized exceptions are thrown in the log. The changes still get pushed correctly but having the null pointer exception isn't ideal. Reproduce
Actual 2022-07-13 10:48:46,689 INFO vecopy.actions.PropagateMasterContentChangesHelper: Checking if childNodes for: /home0 should be deleted 2022-07-13 10:48:46,734 ERROR info.magnolia.commands.MgnlCommand : An error occurred while rewriting links for slave page due to: java.lang.NullPointerException: null at info.magnolia.livecopy.actions.rewire.StandardRewirePageLinksHelper.rewriteLinksForNode(StandardRewirePageLinksHelper.java:95) ~[magnolia-livecopy-3.2.9-SNAPSHOT.jar:?] at info.magnolia.livecopy.actions.rewire.RewirePageLinksHelper.rewritePageLinks(RewirePageLinksHelper.java:59) ~[magnolia-livecopy-3.2.9-SNAPSHOT.jar:?] at info.magnolia.livecopy.command.PropagateMasterContentChangesCommand.lambda$5(PropagateMasterContentChangesCommand.java:101) ~[magnolia-livecopy-3.2.9-SNAPSHOT.jar:?] at java.util.ArrayList.forEach(ArrayList.java:1541) ~[?:?] at info.magnolia.livecopy.command.PropagateMasterContentChangesCommand.rewritePageLinks(PropagateMasterContentChangesCommand.java:99) ~[magnolia-livecopy-3.2.9-SNAPSHOT.jar:?] at info.magnolia.livecopy.command.PropagateMasterContentChangesCommand.execute(PropagateMasterContentChangesCommand.java:64) ~[magnolia-livecopy-3.2.9-SNAPSHOT.jar:?] at info.magnolia.commands.MgnlCommand.executeSynchronized(MgnlCommand.java:80) ~[magnolia-core-6.2.21.jar:?] Expected Notes The feedback I get is that an internationalized site is required. There is no mention of it in the documentation. From a technical point of view the code still works without it. Maybe this could be replaced with a warning or doc update. |