[MAGNOLIA-1023] workflow comments not saved Created: 04/Sep/06  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: workflow
Affects Version/s: 3.0 RC2
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Chris Miner Assignee: Philipp Bärfuss
Resolution: Won't Do Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

unrelated


Attachments: Text File patch.txt    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

If you create a workflow with several participants you can see that comments entered by one participant are not saved. Further investigation shows that the dialog isn't submitted and perhaps this is the reason the entered comment never makes it back to the server.



 Comments   
Comment by Chris Miner [ 05/Sep/06 ]

After looking into this problem, I see now that the dialog save mechanism is intentially bypassed, and the comments find there way back to magnolia through another means. I also see now that although the inbox presents a comments dialog for each of the actions, proceed, reject, and cancel, it only stores the comment entered in the case of the reject action.

I don't think it makes much sense to present the dialog, and then not actually capture the comments in the case of proceed and and cancel. So I uploaded a patch that passes comments throught for the other actions as well.

Comment by Chris Miner [ 05/Sep/06 ]

Patch for including comments in the event of save or cancel actions to match how the reject action works.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:22:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.