[MAGNOLIA-1041] ContentNodeIterator in 3.0 doesn't properly nest node collections + loses localContentNode Created: 12/Sep/06  Updated: 23/Jan/13  Resolved: 12/Sep/06

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 3.0 RC3
Fix Version/s: 3.0 RC3

Type: Bug Priority: Major
Reporter: David Smith Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 10m
Time Spent: Not Specified
Original Estimate: 10m
Environment:

NA


Attachments: Text File ContentNodeIteratorFix.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

savePrevState doesn't always run because of possible exceptions just before savePrevState() is called, but restorePrevState always does. Need to introduce a flag so restorePrevState() only executes if savePrevState() does. Net effect: localContentNode can end up being null, breaking the ability of NewBar to properly create nested paragraphs.



 Comments   
Comment by David Smith [ 12/Sep/06 ]

This patch fixes the bug

Comment by Philipp Bracher [ 12/Sep/06 ]

Thanks: applied.

Remark: your patches are always a complete replacement of the code and not replacing only few lines (as it is normal for patches). Not sure if it is your tortoise client or we have to set the property svn:eol-style on svn to native everywhere.

Comment by Philipp Bracher [ 12/Sep/06 ]

Can it be that a patch for the edit bar was missed?

I updated the edit bar tag so that it works now. Can you verify this?

Comment by David Smith [ 12/Sep/06 ]

Hmmm... I thought the edit bar was already using localContentNode . Thanks for the catch.

Just did a fresh build of revision 6352 - no problems creating, editing, or deleting.

Generated at Mon Feb 12 03:23:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.