[MAGNOLIA-1108] Cannot compile trunk with JDK 1.4.2 (mvn install) Created: 04/Oct/06 Updated: 23/Jan/13 Resolved: 19/Oct/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 3.0 RC3 |
| Fix Version/s: | 3.0 RC4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Anthony Ogier | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
JDK 1.4.2_12, Windows XP, Eclipse WTP 3.2 |
||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
In the trunk version (6553), the command "mvn install" with JDK 1.4.2 ends with that message : I think the maven-setproperty-plugin has been compiled with JDK 5.0 and not with backwards compatibility on JDK 1.4 Here is the complete log for the command : this realm = plexus.core.maven this realm = plexus.core |
| Comments |
| Comment by Magnolia International [ 18/Oct/06 ] |
|
We're now using 1.5, for tests only. We're still compiling the code base as source/target 1.4, so there's no impact for end users, only for developers. 1.5 brings a lot of cool features for testing. If you need proof, try to rewrite the new tests using easymock with 1.4 and you'll see how much more verbose and boring the tests will become I intended to send a quick heads-up mail about this, but you beat to it, so here it is With time, I hope you'll see more and more tests making their way into magnolia, and I believe you'll see the benefit of 1.5 for this very clearly. |
| Comment by Magnolia International [ 18/Oct/06 ] |
|
(the specific issue you had there has been fixed, though, by rebuilding our maven plugins against 1.4) |
| Comment by Anthony Ogier [ 18/Oct/06 ] |
|
I confirm that it is still an issue, as the maven-setproperty-plugin 1.0 downloaded from http://svn.magnolia.info/maven/m2/info/magnolia/maven-setproperty-plugin/1.0/maven-setproperty-plugin-1.0.jar is still compile using source/target 1.5. |
| Comment by Magnolia International [ 18/Oct/06 ] |
|
ok - reopening until we rebuild/redeploy this - sorry. |
| Comment by Magnolia International [ 19/Oct/06 ] |
|
Done : maven-setproperty-plugin redeployed. Please clean your local repository (~/.m2/repository/info/magnolia/maven-setproperty-plugin) |
| Comment by Anthony Ogier [ 19/Oct/06 ] |
|
Thanks Grégory, it's now working (with -Dmaven.test.skip=true, because surefire tests still doesn't work with 1.4.2) |
| Comment by Magnolia International [ 19/Oct/06 ] |
|
And they won't. As a developer, what prevents you from using 1.5 ? See |