[MAGNOLIA-1144] wf: NPE waiting to happen in JCRExpressionStore$StoreIterator.next() logging. Created: 15/Oct/06  Updated: 16/Oct/06  Resolved: 16/Oct/06

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0 RC4

Type: Bug Priority: Major
Reporter: Chris Miner Assignee: John Mettraux
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Looking through the StoreIterator code I noticed the logging statement potentially causes a NPE. It is reasonable to expect that the call to fetchNext() above the logging statement will return null from time to time. If logging is enabled, then this will produce a NPE.

The logging statement should look something like:
log.debug("next() is "+ ((this.next != null) ? this.next.getId().toString() : "null"));



 Comments   
Comment by John Mettraux [ 16/Oct/06 ]

Patch applied.
svn 6762.

Generated at Mon Feb 12 03:24:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.