[MAGNOLIA-1185] Provide a generic bypass mechanism for Filters Created: 06/Nov/06 Updated: 23/Jan/13 Resolved: 27/Apr/07 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | 3.0 RC4 |
| Fix Version/s: | 3.1 M1 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Philipp Bärfuss |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
There currently is a bypass mechanism in MgnlCmsFilter. This needed to be copied for the RegistrationFilter (EE), and should ultimately be available to any filter - using the * notation. |
| Comments |
| Comment by Magnolia International [ 06/Nov/06 ] |
|
+ add tests and make sure the configuration gets properly reloaded on the fly |
| Comment by Sameer Charles [ 16/Nov/06 ] |
|
Bypass should be a handled by the filter chain manager and not by each filter, each filter can have this configuration node but the responsibility of skipping a filter should lie with the chain management. In addition we should use SimpleURLPattern to handle wild cards like we implemented in cache and access control |
| Comment by Philipp Bracher [ 26/Apr/07 ] |
|
We use now the toBean method to create the filters. The filters can have any kind of properties. The each bypass is now a node allowing custom implementations. Since this is an interface any kind of bypass logic is supported. The chain askes the filter if he bypasses the request or not. Normale filters (not implementing MagnoliaFilter) can be integrated by using the FilterDelecator class. This delecator uses a node config to create a simple map used as FilterConfig (see tests). |
| Comment by Philipp Bracher [ 27/Apr/07 ] |
|
This is done for now. I will add new issues for farther changes. |