[MAGNOLIA-1229] Pre-compile JSPs (but not including them in the bundle) Created: 21/Nov/06 Updated: 23/Jan/13 Resolved: 18/Dec/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | build |
| Affects Version/s: | 3.0 Final |
| Fix Version/s: | 3.0.1, 3.0.2 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
As a matter of jdk1.4 compatibility safety, we should try to pre-compile the JSPs of each module, just to make they'll run with 1.4 (see |
| Comments |
| Comment by Magnolia International [ 29/Nov/06 ] |
|
the jspc plugin for maven ( http://mojo.codehaus.org/jspc-maven-plugin ) does not work for non-war projects. Should be easy enough to patch and have the patch applied on their svn though. |
| Comment by Magnolia International [ 05/Dec/06 ] |
|
Currently using a custom snapshot. |
| Comment by Magnolia International [ 05/Dec/06 ] |
|
I tried to have it use tomcat 5.0.28 but this didn't work - possibly due to an incompatibility between the plugin and the jspc api. Should not be too problematic, though - both versions of tomcat comply to the same jsp spec afaik. [INFO] JSPC Error Embedded error: Unable to compile class for JSP Generated servlet error: |
| Comment by Magnolia International [ 05/Dec/06 ] |
|
This now works (using tomcat 5.5's jspc) All one needs to add the get the JSPs verified is: (done for samples and dms) |
| Comment by Magnolia International [ 05/Dec/06 ] |
|
(the "[WARN] Internal Error: File /WEB-INF/web.xml not found" message can safely be disregarded) |
| Comment by Magnolia International [ 08/Dec/06 ] |
|
Reopening because this doesn't work when building w/ reactor |
| Comment by Magnolia International [ 11/Dec/06 ] |
|
One of things I noticed while debugging is that the classpath built for the jspc mojo refered to jars, except for the dependencies directly depended upon by the module (adminInterface and the 2 taglibs), which were refered by their target/classes directory. This wasn't deemed normal on irc#maven but we couldn't figure out what was wrong. |
| Comment by Magnolia International [ 12/Dec/06 ] |
|
now works, since |
| Comment by Fabrizio Giustina [ 15/Dec/06 ] |
|
Hi Grégory, looks like jsp compilation for dms only works when building the module directly, not during a full magnolia build. Could you give it a try? |
| Comment by Magnolia International [ 18/Dec/06 ] |
|
I'll look at it, but note that dms has been removed from the reactor build, as it now has its own lifecycle and will be moved to community modules soon. |
| Comment by Magnolia International [ 18/Dec/06 ] |
|
Removed the usage of a non-used taglib and it now works. Not sure it's really related, but that's all I could do/see. |