[MAGNOLIA-1234] Layout issue with Resin Created: 28/Nov/06  Updated: 18/Feb/14  Resolved: 06/Dec/06

Status: Closed
Project: Magnolia
Component/s: samples, templating
Affects Version/s: 3.0.1
Fix Version/s: 3.0.1

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File resin-layout-issue.patch     PNG File resin-layout-issue.png     File tomcat-resin.diff    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Since MAGNOLIA-958 and related issues have been fixed, I now experience strange layout issues with resin. Since this only happens on content, not on the admin interface, I'm vaguely suspecting some JSP compilation issue. See attached screenshot.



 Comments   
Comment by Magnolia International [ 29/Nov/06 ]

Here's a diff between the rendering on tomcat 5.0 and resin 3.0.21.
Apparently, the spacer div is closed at a different moment in resin !?

Comment by Magnolia International [ 29/Nov/06 ]

So, the issue is due to how resin handles empty tags in jspx.
Here's a patch that's more of a workaround to avoid the "spacer" div (eventhough it actually is a nicer practice to use padding/margin like this, the same problem might occur in other circumstances)
Let's review this ?

Comment by Magnolia International [ 06/Dec/06 ]

In jspx, Resin transforms empty tags to their short for (<div ... />), and it seems browsers don't handle this.
The fix actually just removes these empty tags from the templates, and add a bottom margin the div on top.

Comment by Magnolia International [ 06/Dec/06 ]

patch applied.

Generated at Mon Feb 12 03:24:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.