[MAGNOLIA-1249] User and Roles dialog boxes does not synchronize saving between sessions Created: 04/Dec/06  Updated: 23/Jan/13  Resolved: 04/Dec/06

Status: Closed
Project: Magnolia
Component/s: admininterface
Affects Version/s: 3.0 Final
Fix Version/s: 3.0.1

Type: Bug Priority: Blocker
Reporter: Sameer Charles Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

post save methods in all gui dialogs does not synchronize, as a result either you have a broken session or a broken node when using jackrabbit

to reproduce simply try to edit single user or role from 2 different authors.
its the reposibility of the application to synchronize rather then the core api or the repository,

either use jcr locking or atleast synchronize on singleton object



 Comments   
Comment by Sameer Charles [ 04/Dec/06 ]

In addition, onSave is using current user session to write to the repository and postSave uses system session
its bound to fail!

Comment by Sameer Charles [ 04/Dec/06 ]

for the time I used singleton ExclusiveWrite as used in onSave to synchronize

Problem with synchronize on ExclusiveWrite is that it synchronizes on the entire system, which means no save operations are allowed (even in other workspaces) when you are saving anything with the gui.
I think we should use content.lock() to synchronize between sessions.

atleast it does not break now, but leave this issue open since this is true for all dialogs in magnolia.

Comment by Sameer Charles [ 04/Dec/06 ]

User and Roles save control is fixed as other dialogs.
created another task for improvement MAGNOLIA-1252

Generated at Mon Feb 12 03:25:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.