[MAGNOLIA-1260] replace hard coded version in pom.xml files for dependencies to ${parent.version} Created: 08/Dec/06 Updated: 17/Mar/09 Resolved: 08/Dec/06 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | build |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Nicolas Modrzyk | Assignee: | Philipp Bärfuss |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0.5h | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | 0.5h | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
this is similar to what is done with the openwfe version in the workflow module ... Just noticed it while creating a new build from the trunk |
| Comments |
| Comment by Magnolia International [ 08/Dec/06 ] |
|
There have been discussions on the list with Fabrizio and Philipp as to why we should not do this with ${pom.version} or ${project.version} , as far as I understood, partly because of bugs in the release plugins, partly because you should not really on runtime properties of the pom. I'm not sure where this stands, but its different from the openwfe.version property, since that one is declared with <property> in that same pom. Philipp, could you check / comment ? |
| Comment by Fabrizio Giustina [ 08/Dec/06 ] |
|
you should not use a property for any version number that can be changed during a release or deploy. |
| Comment by Magnolia International [ 08/Dec/06 ] |
|
thanks again for the clarification, Fabrizio |
| Comment by Nicolas Modrzyk [ 11/Dec/06 ] |
|
not sure I understand Fabrizio's answer, since we're using Maven release plugin AND the ${parent.version} thingie for 6 months here now, and it works for both use snapshots and release versions ... My build from the trunk was using 3.0.1 version in the war file, while the version was 3.0.2-SNAPSHOT, why is this better again ? |
| Comment by Fabrizio Giustina [ 11/Dec/06 ] |
|
ok, long answer, there are 3 different issues here:
hope this help |