[MAGNOLIA-1285] modules: dependency check should get impoved (flexible version mappings) Created: 20/Dec/06  Updated: 23/Jan/13  Resolved: 07/Aug/07

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.0.1
Fix Version/s: 3.1 M3

Type: Improvement Priority: Major
Reporter: Philipp Bärfuss Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MAGNOLIA-1421 Samples should not be bootstrapped wh... Closed
is depended upon by MAGNOLIA-1602 Update mechanism Closed
duplicate
is duplicated by MAGNOLIA-1209 Module dependencies should be able to... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

If a module depends on an other module by defining the version 1.0-m2 for exaple, it would not axecpt the version 1.0-rc1 but should do so in my opinion



 Comments   
Comment by Philipp Bracher [ 17/Jan/07 ]

A fist patch uses StringUtils.indexOfDifference to calculate the difference.

1.1 fits 1.1.3, 1.1-SNAPSHOT, ..

1.1 doesn't fit 1.2

A better fully felxible solution would be to note the version number with regexp. To have at least the posibility to react in the current code, I made the methods checkDependencies, checkDependency and checkDependencyVersion of the class ModuleRegistration protected.

Comment by Magnolia International [ 07/Aug/07 ]

Done.
See VersionRangeTest for possibilities.
(In short, a module can depend on another with version "1.2.3" or "1.2.3/" or "/1.2.3" or "1.2.3/1.3.4" etc.)

Generated at Mon Feb 12 03:25:27 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.