[MAGNOLIA-1334] French translations for the workflow module Created: 31/Jan/07  Updated: 23/Jan/13  Resolved: 26/Feb/07

Status: Closed
Project: Magnolia
Component/s: workflow
Affects Version/s: None
Fix Version/s: 3.0.2

Type: Improvement Priority: Major
Reporter: Guillaume Pichenot Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

All


Attachments: File messages_fr(v2).properties     File messages_fr.properties    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Workflow module has not been translated yet.
Don't know for sure if or how "Workflows" or "Workitems" need to be translated, but other words like "Comment" "Proceed", "Reject", "Exception", and more importantly to non-english-speaking user, the Javascript alert dialog announcing the workflow launch need translation.



 Comments   
Comment by Guillaume Pichenot [ 31/Jan/07 ]

First version of the translation.
"Agressive" approach : workflow -> "processus", "workitem" -> tâche.

Comment by Magnolia International [ 01/Feb/07 ]

Thanks a lot Guillaume. I'll review and apply asap - in case of doubts, I'll leave out the translations about which I'm not convinced about for further review/discussion, but this seems great at first sight !

In this one, one remark, though: you used "processus" in the inbox messages, but not in the "started" messages; maybe we should also find a translation for "inbox" (and thus also translate the menu item)

Comment by Guillaume Pichenot [ 01/Feb/07 ]

Right about that mistake.
Here's my second take. Everything should be fairly in sync between all my translations by now.

Same approach as for the rest. It gives something along the lines of :
"Le processus a été activé. La tâche est transférée dans la boîte à lettres appropriée."

About renamming the "inbox" in the admin menu, there's an issue of hardcoding of this name up untill now. I'm not that sure I get it right, though.

From what I gather, it's hardcoded in the config.modules.adminInterface.config.menu.inbox.xml bootstrap file.
It's an easy fix to update this to a dynamic value, but which one should we get :

  • Quick solution is to use the historical menu.inbox from admin module's properties. But since the Workflow is a separate module, with a separate set of properties files, it feels a little "hack-y". I already have the patch for that.
  • Other solution is to set a new value in this module's properties file, and a deletion in each of the admin module's.
Comment by Magnolia International [ 01/Feb/07 ]

Thanks !
If the "Other" solution works, yes, we should go for that

Comment by Guillaume Pichenot [ 05/Feb/07 ]

I've been trying quikcly the "Other solution", but it appears that it does not work, at least, not out of the box.

From what I understood in the Messages classes, when the Navigation class draws the navigation in the Admin central, it uses Messages.getMessages() to get international Strings, and this is equivalent to make the Messages class fall back to its default package for strings, which is the admininterface.properties.

This is certainly an acceptable behavior, for many reasons, but it doesn't help here, and changing that is far beyond the scope of my "simple" translations.

If I'm correct (remains to be seen if I am), thought, it might be a good improvement to update the navigation class to look in both the admininterface properties AND the module's properties.

As for translation, I think I'll upload tonight my final patches (may be using "quick solution"), and we'll go from there if there are mistakes.

Comment by Guillaume Pichenot [ 08/Feb/07 ]

Just to confirm that the v2 file is the my final version.

Comment by Magnolia International [ 26/Feb/07 ]

commited to trunk and 3.0-branch

Generated at Mon Feb 12 03:25:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.