[MAGNOLIA-1352] HierarchyManager should be an interface (testing and delegating) Created: 07/Feb/07 Updated: 23/Jan/13 Resolved: 07/Aug/07 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | core |
| Affects Version/s: | None |
| Fix Version/s: | 3.1 M2 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
|||||||||||||||||||||||||||||||||||
| Issue Links: |
|
|||||||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||||||||||||
| Description |
|
In order to ease testing, and to allow easier change of behaviour like "deferred saving in hierarchy manager" ( see |
| Comments |
| Comment by Magnolia International [ 07/Feb/07 ] |
|
Am currently going in that direction with the interface HierarchyManagerWrapper in the magnolia-module-workflow-deferred-storage branch. This could be generalized for Magnolia 3.1 |
| Comment by Philipp Bracher [ 08/Feb/07 ] |
|
In the we make interfaces for Content and NodeData too |
| Comment by Oliver Lietz [ 10/Feb/07 ] |
|
While you are working on HierarchyManager, Content and NodeData: can you remove the page/website related terms? I couldn't find any useful documentation for the Magnolia internal stuff and working with sources only, maybe other developers are confused by this nomenclature. Would be nice if this classes are more abstract in meaning of terms and node handling. |
| Comment by Oliver Lietz [ 14/Feb/07 ] |
|
| Comment by Magnolia International [ 02/Apr/07 ] |
|
applied patch for Tree(except I made the new method protected, as per your usecase) and HierarchyManager (except for the rename of the setStartPage method which is deprecated anyway) |
| Comment by Magnolia International [ 02/Apr/07 ] |
|
The HierarchyManager interface is now in the new info.magnolia.api package. The implementation is still in info.magnolia.cms.core but has been renamed to DefaultHierarchyManager |
| Comment by Philipp Bracher [ 06/Apr/07 ] |
|
In my opinion it is very important to use in magnolias core more jcr-api than magnolia-api.
|
| Comment by Magnolia International [ 18/Jun/07 ] |
|
Will move the HierarchyManager interface back to info.magnolia.cms.core for now. Expect new package structure for 3.2, maybe along with some new/removed/renamed methods |
| Comment by Magnolia International [ 07/Aug/07 ] |
|
done since a while. improving the interface itself is another task. |