[MAGNOLIA-1353] bootstrapping: custom mime types are not bootstrappable Created: 07/Feb/07  Updated: 23/Jan/13  Resolved: 27/Nov/07

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.0.1
Fix Version/s: 3.5 RC1

Type: Bug Priority: Major
Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-1858 Review MIMEMapping and make it a prop... Closed
is related to MAGNOLIA-1373 User configuration should have priori... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MAGNOLIA-1418 Move mime types bootstrap files to we... Sub-task Closed Sameer Charles  
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The bootstrapp file for the server/MIMEMapping is for no reason in the admin interface module. This prohipits having own mimetype bootstrap files in the bootstrap folder of the webapp or in other modules.



 Comments   
Comment by Fabrizio Giustina [ 22/Feb/07 ]

a generic note on the problems with bootstrapping content into /server from modules (is discussed here and in a couple of other issues)
I agree that modules should probably only bootstrap things in /modules, but I would also like to avoid putting anything in WEB-INF/bootstrap which should be a default configuration. IMHO everything that is a default should be embedded in jars (easy project setup, easy migration), but should be overwritable by user files in WEB-INF/bootstrap.

Maybe we should define a bootstrapped directory in core with this items? That directory would be bootstrapped BEFORE user files and modules so content will always be overridden by custom configuration.
The goal should be the magnolia could bootstrap and work with default settings also WITHOUT putting anything in WEB-INF/bootstrap

Comment by Sameer Charles [ 22/Feb/07 ]

I agree that all core (base system) bootstrap files should be in core jar like all modules have in appropriate module jars
this definately will be a step forward to make updates easier.

But, since we are talking about minor release here and I havent looked at the bootstrap mechanics so I cannot say if its feasible
to do so for 3.0.2 release.

what you guys think?

Comment by Magnolia International [ 22/Feb/07 ]

core isn't a module at the moment, so it won't bootstrap files.
for 3.0.2, I'd either postpone, or move the mimetype bootstrap files to the webapp, nothing more.
for 3.x, we could review the modularization of core/adminIntf/gui, but that sounds more like 3.2 to me.
(and i totally agree that defaults should be in jars, overridable by WEB-INF/bootstrap)

Comment by Fabrizio Giustina [ 24/Feb/07 ]

> for 3.0.2, I'd either postpone, or move the mimetype bootstrap files to the webapp, nothing more.
I agree, a change in bootstrap will go into 3.1

My proposal is to add a bootstrap dir to core (mgnl-bootstrap or mgnl-core) and to load files in the following order:

  • default in core
  • modules
  • user (bootstrap dir in webapp)

this way anything added by user could overwrite the default both for core and for modules.
If everybody agree with this I'll open a separate issue and start working on that on trunk.

Comment by Sameer Charles [ 26/Feb/07 ]

moved MIMEMapping.xml to webapp only on 3.0.2 branch.

Comment by Philipp Bracher [ 08/Mar/07 ]

I agree to move main bootstrap (default configuration) to the core jar.

Thinking about the update mechanism we will implement for modules/main system, the core could be indeed a module on which admin interface depend on.

This would reduce the complexity since we only have to handle one kind of jars (bootstrapping & updating)

Comment by Magnolia International [ 22/Nov/07 ]

Will check this for RC2 - if no change required, will reset "fix version" to RC1.

Comment by Philipp Bracher [ 27/Nov/07 ]

is solved:

  • the webapp bootstrap is executed in the end
  • all nodes in /server can be overwritten
  • the default mime type definitions are in the core module now
Generated at Mon Feb 12 03:26:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.