[MAGNOLIA-1357] The <cmsu:scaleImage tag creates a new node, but not the binary data of the scaled image. Created: 08/Feb/07  Updated: 23/Jan/13  Resolved: 13/Apr/07

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 3.0.1
Fix Version/s: 3.0.3, 3.1 M1

Type: Bug Priority: Minor
Reporter: Hartmut Kern Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Mac OSX, Java 1.4 and 1.5


Attachments: Text File BaseImageTag.java.patch     Text File ScaleImageTag.java     Text File ScaleImageTag.java.patch     Text File ScaleImageTag.java.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

In any way it doesn't work as expected. It is useless as it is now. I really need it and thinking about to fix the bug, or improve the functionality, if it is ok.



 Comments   
Comment by Philipp Bracher [ 15/Feb/07 ]

fixing things and providing a patch is always welcome

Comment by Hartmut Kern [ 19/Feb/07 ]

Fine. Hope I'll do it well.
Hartmut

Comment by Fabrizio Giustina [ 19/Feb/07 ]

I confirm that the scaleImage tag doesn't work properly on current svn trunk...
the tag should be refactored anyway, it should subclass BaseImageTag that supply all the methods for correctly wring an image node (not sure if it's ok too). I will have a look at them too.

Comment by Thomas Duffey [ 27/Feb/07 ]

An attempt at modifing ScaleImageTag to subclass BaseImageTag.

Sadly, the feature still isn't working. I'll try to work on it some more tonight.

Comment by Magnolia International [ 27/Feb/07 ]

Please provide patches, makes our lives much easier ! thanks anyway.

Comment by Thomas Duffey [ 28/Feb/07 ]

Use this patch against 3.0.1. After applying the patch the tag is working for me.

Comment by Hartmut Kern [ 11/Mar/07 ]

Thanks, all of you. Yes it works now in my environment (Mac OSX, Java 1.4 and 1.5, Magnolia 3.0x). Do you think it would help to write a small docu and a example (may be why I am using it? I wrote a community template, and working on something like flickr)
Hartmut

Comment by Boris Kraft [ 12/Mar/07 ]

well, provide a patch (here, in jira, as an attachment)
For your community template, write a wiki entry that explains what it does and how to do it. see http://www.magnolia.info/wiki/

Comment by Thomas Duffey [ 09/Apr/07 ]

Patch to update the last modified date on the scaled image node.

Comment by Thomas Duffey [ 09/Apr/07 ]

Latest patch to ScaleImageTag.java. This one adds two new features:

  • Rebuilds the scaled image whenever the full size image is updated.
  • Rebuilds the scaled image whenever the scaling parameters (maxHeight and maxWidth) change in the template.
Comment by Philipp Bracher [ 13/Apr/07 ]

commited

Generated at Mon Feb 12 03:26:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.