[MAGNOLIA-1362] Activating a subtree (Activate inc. sub pages) only shows the root page of the subtree in the Inbox Created: 08/Feb/07  Updated: 23/Jan/13  Resolved: 03/Sep/08

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 3.0.1
Fix Version/s: 3.6

Type: Bug Priority: Blocker
Reporter: zam6ak Assignee: Jan Haderka
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Magnolia enterprise 3.0.1
JBoss AS 4.0.5GA


Attachments: Text File subpages-dialog-error.log    
Issue Links:
relation
is related to MAGNOLIA-1632 Inbox shows only page name without fu... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

To reproduce

1. Create two pages pageA and pageB where pageA is a partent of pageB
2. Select "Activate inc. sub pages" option on page A. This will activate page A and pageB...
3. However, Inbox only shows pageA for approval...There is no pageB anywhere being mentioned....

Was there a notion that if I approve pageA all of its chidren are automatically approved as well? If so is there a way to distinguish this in the Inbox (approving single page vs a subtree)...
I feel, however that each page in the subtree should be approved separately or give an option to "bulk" approve pages belonging to a subtree...(see http://jira.magnolia.info/browse/MAGNOLIA-998)

Regards
Amir



 Comments   
Comment by Philipp Bracher [ 24/May/07 ]

Well we should do it in a better way but this is better than what we had before:

  • the dialog shows the recursive flag
  • a warning comment is added to the workitem (showed in the inbox list)

The problem is that we try to keep the inbox neutral to allow any kind of workflows

Comment by zam6ak [ 24/May/07 ]

One idea to keep the Inbox neutral would be to implement a dialog (or a tab on existing dialog) for the workitem that would show the tree of all pages being activated.
This dialog (or a tab) would only show for workitems which consist of multiple pages and would not require any changes to the Inbox.

Again, I am not an expert on Magnolia API so I am not sure if my idea would work...

Comment by Philipp Bracher [ 25/May/07 ]

This is indeed a possability.

Actually this is a must because the subpages are versioned as well and the publisher should be able to check the versioned subpages as well. But it is not that easy to implement, I guess.

Comment by Philipp Bracher [ 14/Jun/07 ]

In case of a recursive activation the dialog lists all subpages.

  • status (you see which pages were changed)
  • link to the versioned subpage

I will have to cleanup the GUI a bit (column width, ....)

Comment by zam6ak [ 15/Jun/07 ]

There is a problem with dialog when DMS content is being activated.
After activating medium size DMS tree (150 items) and opening workitem dialog a huge stacktrace is produced.

Please see attached stacktrace log for details.

Comment by Philipp Bracher [ 19/Jun/07 ]

I made the DateUtil null save --> the upper stacktrace should not appear again.

But still the links to the documents in the dialog are wrong (will fix that emediatelly).

Comment by Philipp Bracher [ 21/Jun/07 ]

Is working now. We have to cleanup the html of the inbox to bring IE into standard mode so that we can use the standard box model. But this is an other task.

Comment by zam6ak [ 25/Jun/07 ]

I had a chance to test this again with a freshly bootstraped repository...

Two problems I encountered:

  • rendering sub items after opening Inbox dialog is extremely slow. I had activated a site page which had about 100 pages total...It took about 5 minutes for dialog to render and the entire browser during that time is "zombified"...
  • if you click on the versioned page to see the changes the page fails to load if the template uses inherited paragraphs....Huge stacktrace gets generated and none of the inherited paragraphs show on the page making it unreadible...
  • after saving the workitem I get our infamous dialogServlet NPE (see MAGNOLIA-1552)
Comment by Magnolia International [ 25/Jun/07 ]

trying to reproduce :

  • displaying the list of sub-pages is indeed very slow. Firefox isn't blocked at all during that time for me, however. What browser are you using ? what persistence manager are you using ?
  • I don't get any exception upon saving..
Comment by zam6ak [ 25/Jun/07 ]

My FireFox was blocked ...I had about 70 pages in the list. Did you try with a large subset?
-We use Oracle Bundle PM

Comment by Magnolia International [ 25/Jun/07 ]

yup, plenty of pages too. Indeed, there's a period where the browser seems blocked, that's probably related to javascript; I didn't notice it at first, because it's only "blocked" after a while, not immediately when the dialog opens up.

Comment by Philipp Bracher [ 13/Nov/07 ]

As a first fix we will stop rendering after 20 items

Comment by Magnolia International [ 03/Apr/08 ]

will be fixed by introduction of new gui

Comment by Jan Haderka [ 03/Sep/08 ]

The issue seems to be gone on 3.6. Most likely related to changes in handling nodes (mix:versionable) and to cleanup of finished workitems from the inbox. I was able to get dialog for page with approx 120 subpages rendered in 5 seconds (FF 3.0.1, Linux)
Please reopen if you can reproduce the problem with 3.6.1 (or hihger) and provide details on server and browser configuration.

Generated at Mon Feb 12 03:26:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.