[MAGNOLIA-1380] modules: modules should not bootstrap files into server/* Created: 15/Feb/07  Updated: 23/Jan/13  Resolved: 02/Mar/07

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.0.1
Fix Version/s: 3.0.2

Type: Bug Priority: Major
Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
clones MAGNOLIA-1373 User configuration should have priori... Closed
relation
is related to MAGNOLIA-1706 Bootstrap of webapp is now fully and ... Closed
supersession
supersedes MAGNOLIA-1326 ModuleUtil.bootstrap() could accident... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Some of the modules bootstrap content into the config: server part. This avoids overwritting this settings by the default bootstrap mechanism, since they get overwritten during the module registration.

  • modules should not have this kind of bootstrap files
  • if they have to (filter, ....), the should check the existence of the node(s) and bootstrap only in cases where thise are not present.


 Comments   
Comment by Magnolia International [ 02/Mar/07 ]

For the record, here are the module bootstrap files which bootstrap content into config:server/
./magnolia-module-admininterface/src/main/resources/mgnl-bootstrap/adminInterface/config.server.secureURIList.admininterface.xml
./magnolia-module-admininterface/src/main/resources/mgnl-bootstrap/adminInterface/config.server.unsecureURIList.adminJavascript.xml
./magnolia-module-admininterface/src/main/resources/mgnl-bootstrap/adminInterface/config.server.unsecureURIList.logout.xml
./magnolia-module-cache/src/main/resources/mgnl-bootstrap/cache/config.server.filters.cache.xml

Comment by Magnolia International [ 02/Mar/07 ]

Commited a fix in 3.0 branch and trunk that skips bootstrap files for config:/server/ when the node already exists.

Shouldn't this be the case any node?

Comment by Magnolia International [ 02/Mar/07 ]

<for> any node, I meant.

Comment by Philipp Bracher [ 08/Mar/07 ]

NO!

In some cases a module wants to overwrite the corrent content

Generated at Mon Feb 12 03:26:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.