[MAGNOLIA-1387] Make JCRAuthorizationModule more extensible Created: 17/Feb/07  Updated: 18/Feb/07  Resolved: 18/Feb/07

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 3.0.1
Fix Version/s: 3.1 M1

Type: Improvement Priority: Minor
Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

JCRAuthorizationModule contains all the logic for extracting roles and groups from a magnolia user and adding related ACLs.
All the methods that handle groups and roles are private and directly work with a content object, in order to make it more flexible it should be modified by separating the logic for retrieving groups and roles from the one that sets the ACLs.
Instead of directly extract roles and set acls it should:

  • extract all the roles and groups names
  • set acl from the list of roles and group names.

This will make easier to extend it by providing a custom way to collect roles (from an external repo) and to just handle ACLs inside magnolia



 Comments   
Comment by Fabrizio Giustina [ 18/Feb/07 ]

Refactoring committed to trunk. JCRAuthorizationModule should now be easy to subclass (and easier to read)

Generated at Mon Feb 12 03:26:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.