[MAGNOLIA-1440] redeployment util allows module to clobber other modules installed files. Created: 28/Mar/07  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Chris Miner Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When a module is updated, part of the module registration process involves installing files. Only files under mgnl-files containing the module name as part of the path are installed. This is a good thing since it means each module has its own file 'name space'.

However if you trigger redeployment via the deployment utils page, no such check is used. Any file anywhere in the classpath under mgnl-files is unpacked and written to the file system.

You might notice this if your jsps never deploy by themselves and you find yourself having to deploy them manually every time you update your modules version number.



 Comments   
Comment by Philipp Bracher [ 03/Apr/07 ]

I would like to change this as such:

  • update of a (minor) version should not install/bootstrap all files again (might overwrite custom settings)
  • additional onUpdate() method
  • list changed (bootsrap) files (maybe in the modules descriptor)
  • in case magnolia.develop property is set the redeploy thread is running (no additional triggering after each start)
  • the deploy util checks the modification date and checks jsps more often (since this is what you need most)
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:26:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.