[MAGNOLIA-1447] Menu label "Inbox" non-localized due hardcoded value in bootstrap Created: 04/Apr/07  Updated: 23/Jan/13  Resolved: 05/Apr/07

Status: Closed
Project: Magnolia
Component/s: workflow
Affects Version/s: 3.0.2
Fix Version/s: 3.1 M1

Type: Bug Priority: Trivial
Reporter: Henryk Paluch Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 5m
Time Spent: Not Specified
Original Estimate: 5m
Environment:

Magnolia 3.0.2 from svn, dms 1.1.1, Win32, JDK 1.5.0_11


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Admin Central's menu shows hardcoded label 'Inbox' instead of localized version. It is due wrong key in bootstrap repository file. Here is an trivial patch to fix it:

— ./magnolia-module-workflow/src/main/resources/mgnl-bootstrap/workflow/config.modules.adminInterface.config.menu.inbox.xml.orig Tue Sep 12 09:18:27 2006
+++ ./magnolia-module-workflow/src/main/resources/mgnl-bootstrap/workflow/config.modules.adminInterface.config.menu.inbox.xml Wed Apr 4 08:52:43 2007
@@ -23,7 +23,7 @@
<sv:value>MgnlAdminCentral.showContent('/.magnolia/pages/inbox.html', false, false)</sv:value>
</sv:property>
<sv:property sv:name="label" sv:type="String">

  • <sv:value>Inbox</sv:value>
    + <sv:value>menu.inbox</sv:value>
    </sv:property>
    <sv:node sv:name="MetaData">
    <sv:property sv:name="jcr:primaryType" sv:type="Name">

Note that localized menu labels are already in (magnolia-module-admininterface\src\main\resources\info\magnolia\module\admininterface\messages_*.properties) - yes they are part of admininterface (not of workflow)).



 Comments   
Comment by Guillaume Pichenot [ 04/Apr/07 ]

>>Note that localized menu labels are already in (magnolia-module-admininterface)

See one of my previous observations here on that subject :
http://jira.magnolia.info/browse/MAGNOLIA-1334#action_13359

While the patch Henryk reported actually works I don't think it solves the whole of this issue, e.g. the fact that workflow module looks for Strings inside the admininterface's files when drawing navigation in the admin central.

Comment by Philipp Bracher [ 05/Apr/07 ]

menu points support the i18nBasename property. I will add it to the menu point.

Thanks

Comment by Philipp Bracher [ 05/Apr/07 ]

commited

thanks

Generated at Mon Feb 12 03:27:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.