renderers: use them for paragraphs too (MAGNOLIA-1383)

[MAGNOLIA-1462] Create a freemarker-based paragraph renderer Created: 13/Apr/07  Updated: 23/Jan/13  Resolved: 07/Aug/07

Status: Closed
Project: Magnolia
Component/s: templating
Affects Version/s: None
Fix Version/s: 3.1 M2

Type: Sub-task Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MAGNOLIA-1479 Refactor ParagraphRenderer/TemplateRe... Closed
relation
is related to MAGNOLIA-1466 Merge FreemarkerUtil and FreemarkerHe... Closed
Template:
Date of First Response:

 Description   

+sample



 Comments   
Comment by Magnolia International [ 18/Apr/07 ]

This is available on trunk. ActionBasedParagraph can declare a simple actionClass, which gets executed by the FreemarkerParagraphRenderer and made available to the template's context. (the action is currently not populated with any request parameter)

Comment by Philipp Bracher [ 19/Apr/07 ]

Not sure but we should consider to use the pages to do that, they have at least already support for:

  • multiple actions
  • usage of commands
  • setting request parameters
  • simple template selection based on resolved view name

We should avoid implementing the same thing twice. Better improving what we already have.

Comment by Magnolia International [ 20/Apr/07 ]

I agree.
However, the current ABP+FPR is clean, simple and tested. It's now useable as part of 3.1, and was needed for our forum sprint.
Now, I'd be in favor of creating another jira issue (i.e other sprint) to remind us to

  • think about merging the Pages impl and ABP/FPR
  • write tests for further functionality implemented in Pages
  • refactor/merge !
Comment by Magnolia International [ 23/Apr/07 ]

See MAGNOLIA-1479 for further refinements and refactoring with pages

Comment by Magnolia International [ 23/Apr/07 ]

Added support for parameters, set on the action - much like the pages do, but filtered through a "allowedParameters" configuration item. (more secure than just pushing all requests parameters - should add some validation too...)

Comment by Magnolia International [ 07/Aug/07 ]

See MAGNOLIA-1466 and MAGNOLIA-1479 for further improvements

Generated at Mon Feb 12 03:27:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.