[MAGNOLIA-1478] Update velocity dep to 1.5, remove dep to logkit/oro Created: 23/Apr/07  Updated: 23/Jan/13  Resolved: 07/Aug/07

Status: Closed
Project: Magnolia
Component/s: build
Affects Version/s: None
Fix Version/s: 3.1 M2

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-1461 Remove commons-logging Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Eventhough velocity is currently only used in the mail module, updating it will at least allow cleaning up some dependencies.



 Comments   
Comment by Magnolia International [ 23/Apr/07 ]

http://wiki.apache.org/velocity/Velocity15ReleaseNotes

Comment by Fabrizio Giustina [ 23/Apr/07 ]

unfortunately ORO is still required for velocity 1.5 (and logkit has a strange "provided" scope... mhhh).
Upgrading to velocity 1.5 is anyway nice, I wonder why we shouldn't keep only freemarker based templates by default in the mail module...
maybe velocity support should be made optional (compiled and available in the jar, enabled only when velocity is available in the classpath)? that would reduce the list of dependencies for users and I don't think many users will explicitely require velocity as templating engine when freemarker is already available (syntax is very simile and freemarker is way too powerful/clean than velocity now...)

Comment by Magnolia International [ 23/Apr/07 ]

yes, but with 1.5, oro is declared in the velocity pom
re: logkit, from what I read in the velocity docs, velocity automatically uses log4j OR logkit, depending on what's available. hence the provided scope.

I agree on your comment regarding velocity vs freemarker, so we could just put our velocity dependency with scope:provided, maybe.

Comment by Magnolia International [ 23/Apr/07 ]

Dependency updated, now using <groupId>org.apache.velocity</groupId>
(so I had to exclude groupId:velocity from openwfe-engine used in magnolia-module-workflow)

Let's see what we do about the global usage of velocity (maybe that's a 3.2 or later subject, though)

Comment by Philipp Bracher [ 24/Apr/07 ]

Velocity was used for the first steps. Since freemarker is the projects choice in other places we can make the velocity feature optional here.

Comment by Magnolia International [ 07/Aug/07 ]

creating a new issue to remove or make the velocity dependency optional

Generated at Mon Feb 12 03:27:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.