[MAGNOLIA-1479] Refactor ParagraphRenderer/TemplateRenderer Created: 23/Apr/07 Updated: 23/Jan/13 Resolved: 26/Jan/09 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | templating |
| Affects Version/s: | None |
| Fix Version/s: | 4.0 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Description |
|
There is certainly room for improvement and removal of duplicate stuff. TemplateRenderer and ParagraphRenderer could be one single thing. Maybe Pages too.
|
| Comments |
| Comment by Magnolia International [ 23/Apr/07 ] |
|
While we're there, we'll need:
|
| Comment by Magnolia International [ 16/Sep/08 ] |
|
this is something we'll tackle for 3.7 |
| Comment by Philipp Bracher [ 04/Oct/08 ] |
|
Code streamlined, both templates / paragraphs work internally the same way and support actions (jsp / freemarker) |
| Comment by Magnolia International [ 08/Oct/08 ] |
|
I like the AbstractRenderer / Renderable approach, but something bothers me about exception handling: haven't been able to pinpoint it exactly, but previously when a paragraph template had a syntax error, it was appear onscreen in this infamous ugly yellow background. Not cool in production but very useful while working on templates. Now all i get on screen is a RenderException from the page template, wrapping the paragraph's RenderException, but the actual freemarker error message is swallowed and only visible in the logs when scrolling furiously. |
| Comment by Magnolia International [ 26/Jan/09 ] |
|
Done for templates & paragraphs. |