[MAGNOLIA-1523] Aggregator can become a simple bean and be exposed in the context Created: 10/May/07  Updated: 23/Jan/13  Resolved: 17/Oct/07

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: None
Fix Version/s: 3.5 RC1

Type: Improvement Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MAGNOLIA-1512 Request charset should be set before ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

The Aggregator class is currently just a bunch of get/set static methods that delegate to get/setAttribute of MgnlContext. Instead, we could make this class a simple javabean, and expose one instance of it in the (Web)Context



 Comments   
Comment by Magnolia International [ 11/May/07 ]

Done -
New class is called AggregationState and lazily instanciated by the WebContext.
Aggregator is still there, should still work, but is completely deprecated.

One can now do MgnlContext.getAggregationState().getXYZ()

Also deprecated a bunch of methods in Path.
The Resource class now uses AggregationState.

Todo :

  • the original Aggregator.getExtension code was getting the extension from the current URI, and if that was empty, was getting it from the original URI. Now AggregationState.getExtension() only returns what's been set by the ContentTypeFilter. Quid ?
  • RepositoryMappingFilter is resetting the extension, but that seems useless - especially if the above is corrected to behave like Aggregator did.
  • other classes to review, still using the now deprecated code: BasePatternVoter, CacheKey, UUIDRequestDispatcher, ZipUpload
Comment by Magnolia International [ 15/May/07 ]

done:

  • RepositoryMappingFilter is not setting AggregatorState's extension anymore, this is now only done by ContentFilter
  • Reviewed and fixed BasePatternVoter, CacheKey, UUIDRequestDispatcher, ZipUpload

still to do:

  • impl of Aggregator.getExtension - see comment above
Comment by Magnolia International [ 17/Oct/07 ]

AggregationState.setExtension() is okay as is. It currently reflects the original request's uri, but if needed, any filter or other piece of code (VirtualUriFilter for instance) could change it.

Generated at Mon Feb 12 03:27:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.