[MAGNOLIA-1529] URLs with trailing slash result in broken links Created: 11/May/07  Updated: 23/Jan/13  Resolved: 27/Jan/09

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.0 Final
Fix Version/s: 4.0

Type: Bug Priority: Major
Reporter: Boris Kraft Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-2589 Remap different possible url to the s... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

If you type a URL where the last part is a slash instead of .html, e.g.
http://www.magnolia.info/en/products/enterprise-edition/

(instead of http://www.magnolia.info/en/products/enterprise-edition.html)

The resulting page rendering will have its links point to non-existing pages. Specifically, it seems that the top-level folder is taken twice to create the link, i.e. for the above example, a link on the page could be:
http://www.magnolia.info/en/en/products/enterprise-edition/sitedesigner.html
(note the /en/en)

I am not sure what the desired behaviour is, but rendering a page with incorrect links is not desired. EIther return a "page not found" or render the links correctly.



 Comments   
Comment by Magnolia International [ 20/Jan/09 ]

We could have a look at this with 4.0
1) See if the links themselves are still wrongly generated
2) Responding correctly to trailing slashes might be a separate issue which we could push to 4.1 and/or solve with a VirtualURImapping

Comment by Jan Haderka [ 23/Jan/09 ]

Links are now resolved exactly same no matter which way page is accessed:

The doubling effect of the top folder doesn't occur any more.

This is true for both, 3.6.3 and 4.0. Shall we close this or should we re-map first two cases to the 3rd one with virtual URI mapping? (Personally I would leave it as is or at least push this to after 4.0 if we decide to go for it.)

Comment by Boris Kraft [ 23/Jan/09 ]

From an SEO standpoint it would probably be beneficial if all three are the same, and mapped to the third case.

Comment by Jan Haderka [ 23/Jan/09 ]

Indeed. For the 2nd case it should not be so difficult with virtual URI mapping, the first one will be more tricky.

Comment by Jan Haderka [ 27/Jan/09 ]

Links are no longer broken if URI end with /
The remaping of URI to the preferred one (with extension) will be dealt with separately in MAGNOLIA-2589.

Generated at Mon Feb 12 03:27:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.