[MAGNOLIA-1659] always register repositories, nodetypes and workspaces from module definitions Created: 06/Aug/07 Updated: 23/Jan/13 Resolved: 27/Oct/07 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | updatemechanism |
| Affects Version/s: | 3.1 M1 |
| Fix Version/s: | 3.5 RC1 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Fabrizio Giustina | Assignee: | Fabrizio Giustina |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
(related to the new update mechanism, at this moment the registration of new workspaces (also repositories/nodetypes) only happens during bootstrap and it's implemented by rewriting the repositories.xml file that will be loaded at system restart. I propose to change the current implementation by making repositories declared in the module definition always checked. These are the steps that should be always performed while loading a module:
I see several benefits in doing it this way: no restart needed, cleaner implementation and removal of the last bit that still rewrite a user configuration file. It should not have any drawback (if you want to tune your configuration you can still add a repository/workspace configuration to repositories.xml as before) |
| Comments |
| Comment by Fabrizio Giustina [ 11/Aug/07 ] |
|
first draft in svn: Repositories/workspaces/nodetypes needs to be loaded always at startup; if modules need to be installed/updated this is also the firts step to be done.
this means that the creation of repositories is only performed after the user confirmation during an update, and also speedup the loading of magnolia itself. The repository loading in checkForInstallOrUpdates()() could not look so nice, but the only alternative solution is to add another public method/phase that should be called by the config loader. Note also that:
ready for feedbak |
| Comment by Philipp Bracher [ 14/Aug/07 ] |
|
Goes definitely into the right direction. > but the only alternative solution is to add another public method/phase that should be called by the config loader. I think we should choose this way to keep the startup process clean |
| Comment by Fabrizio Giustina [ 27/Oct/07 ] |
|
This already done for 3.1 |