[MAGNOLIA-1662] Wrap modules' servlets in Filters Created: 07/Aug/07  Updated: 23/Jan/13  Resolved: 18/Oct/07

Status: Closed
Project: Magnolia
Component/s: core, updatemechanism
Affects Version/s: None
Fix Version/s: 3.5 RC1

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Vivian Steller
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-1602 Update mechanism Closed
relation
is related to MAGNOLIA-1984 Mappings for wrapped servlets are not... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Since the update mech is not running in a servletcontextlistener anymore, we can't modify the web.xml file anymore, since the container might then try to hot-redeploy the app while the update is still running.
Possibilities:

  • write to another file and inform the user
  • support servlets by wrapping them in a filter (prefered solution)


 Comments   
Comment by Philipp Bracher [ 15/Aug/07 ]

in the meanwhile you have to add the following snipped manually to the web.xml file.

<!-DMS download servlet->
<servlet>
<servlet-name>DMSDownloadServlet</servlet-name>
<servlet-class>info.magnolia.module.dms.DMSDownloadServlet</servlet-class>
</servlet>
<!-DMS download servlet->
<servlet-mapping>
<servlet-name>DMSDownloadServlet</servlet-name>
<url-pattern>/dms/*</url-pattern>
</servlet-mapping>
<!-DMS download servlet->
<servlet-mapping>
<servlet-name>DMSDownloadServlet</servlet-name>
<url-pattern>/dms-static/*</url-pattern>
</servlet-mapping>
<!-Servlet to send email using the email system.->
<servlet>
<servlet-name>Mail</servlet-name>
<servlet-class>info.magnolia.cms.mail.servlets.MgnlMailServlet</servlet-class>
</servlet>
<!-Servlet to send email using the email system.->
<servlet-mapping>
<servlet-name>Mail</servlet-name>
<url-pattern>/.magnolia/mail/*</url-pattern>
</servlet-mapping>

Comment by Vivian Steller [ 18/Oct/07 ]

MAGNOLIA-1662: fixed.

  • introduced ServletDispatchingFilter (one Filter for every Servlet, grouped in one composite "servlets" filter)
  • updated install task for registering servlets
  • updated bootstrap file that filter chain is aware of "servlets" node
  • updated module descriptors appropriately so that each module now registers its servlets
  • moved fckeditor servlet to right module

as of now, only one filter and two listeners are required in web.xml to run magnolia... cool

Generated at Mon Feb 12 03:29:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.