[MAGNOLIA-1737] Method resolveNode() in BaseContentTag doesn't care about paragraphs Created: 12/Sep/07  Updated: 23/Jan/13  Resolved: 18/Sep/07

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 3.0.3
Fix Version/s: 3.0.4

Type: Bug Priority: Blocker
Reporter: Jürgen Hirt Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

From version 3.0.3 on, there's a change in the method resolveNode(Content currentPage) in the class BaseContenTag.
In line 153, instead of the currentParagraph, the currentPage now is returned:
...
// e.g. <cms:out nodeDataName="title"/>
return currentPage;
...

Is it okay, that paragraphs aren't considered any more at all in this method ?

I had big problems, because I used the following Tag to store the paragraph node in a variable:
<cms:setNode var="currentNode" />

currently, if the value of this node is read later, the result is null !!

I now use the attribute contentNodeName of this setNode-Tag as a workaround by naming the paragraph directly, but this is a very bad solution in my opinion..

could you perhaps have a look at it ?



 Comments   
Comment by Sean McMains [ 14/Sep/07 ]

This change broke many of our paragraphs as we're moving to 3.0.3 as well. Judging by the documentation, the original functionality was correct.

Comment by Sean McMains [ 17/Sep/07 ]

This also breaks some of the sample paragraph types as well, notably text-image and table.

Comment by Philipp Bracher [ 18/Sep/07 ]

Priority level of the bug increased.

Comment by Philipp Bracher [ 18/Sep/07 ]

The change was done by a commit regarding to MAGNOLIA-1618.

I reverted 9962.

This is probably worth a immediate 3.0.4

Generated at Mon Feb 12 03:29:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.