[MAGNOLIA-1743] WarnTasks regarding deprecated content in web.xml should not be executed when *installing* core, only when updating Created: 17/Sep/07  Updated: 23/Jan/13  Resolved: 06/Nov/07

Status: Closed
Project: Magnolia
Component/s: core, updatemechanism
Affects Version/s: 3.1 M3
Fix Version/s: 3.5 RC1

Type: Improvement Priority: Minor
Reporter: Fabrizio Giustina Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MAGNOLIA-1767 update mechanism: manual tasks Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

While doing a clean bootstrap of the current trunk I get the following warning, although I am not updating an older version:

WARN info.magnolia.module.InstallContextImpl.warn(InstallContextImpl.java:53) > CacheGeneratorServlet has been removed in Magnolia 3.1: please remove the corresponding <servlet> and <servlet-mapping> elements in your web.xml file.
WARN info.magnolia.module.InstallContextImpl.warn(InstallContextImpl.java:53) > MagnoliaManagedFilter was renamed to MagnoliaMainFilter: please update the corresponding <filter-class> element in your web.xml file.

Those are now unconditionally added in info.magnolia.setup.CoreModuleVersionHandler, instead the in the deprecated classes as before. They should be conditional



 Comments   
Comment by Magnolia International [ 23/Oct/07 ]

One of the issues is explained in a TODO of the CoreModuleVersionHandler: "currently core is always installed since 3.1 is its first version as a module".

Comment by Magnolia International [ 06/Nov/07 ]

done.
regarding the "core-3.1 is installed" issue, basically, each task determines the status itself. We'll be able to get rid of these workarounds with the next major version.

Generated at Mon Feb 12 03:29:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.