[MAGNOLIA-1776] Changing template renderers in order to use include instead of forward Created: 11/Oct/07  Updated: 17/Dec/07  Resolved: 11/Oct/07

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.1 M3
Fix Version/s: 3.5 RC1

Type: Improvement Priority: Major
Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MAGNOLIA-1196 Using MagnoliaFilterChain as <dispatc... Closed
is depended upon by MAGNOLIA-1698 Review usage of originalURI/currentUR... Closed
supersession
is superseded by MAGNOLIA-1964 Use forward() in JspTemplateRenderer ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

The jsp template renderer actually uses a forward in order to render jsps.
This is the primary problem for which the magnolia filter can't be mapped with "forward" dispatcher in web.xml and could cause other problems when integrating magnolia with other MVC frameworks.

We will change it in 3.1 in order to include jsps instead of forwaring to them.

The simple change is as following:

RequestDispatcher rd = request.getRequestDispatcher(requestReceiver);

  • rd.forward(request, response);
    + rd.include(request, response);

Note that this could require updating any custom filter mapping (not the magnolia one) you may have mapped to *.jsp only, when upgrading a custom application based on a previous version of magnolia.



 Comments   
Comment by Fabrizio Giustina [ 11/Oct/07 ]

fix committed for 3.1

Generated at Mon Feb 12 03:30:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.