[MAGNOLIA-1784] build : samples' jsps can't be compiled in reactor mode since introduction of cmsfn Created: 16/Oct/07  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: build
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-2538 Parent poms V6 and updated build tools Closed
is related to MAGNOLIA-1419 build of magnolia-module-samples fail... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

[INFO] Trace
org.apache.jasper.JasperException: file:/Users/gjoseph/Dev/magnolia/svn/magnolia/trunk/magnolia-module-samples/src/main/resources/mgnl-files/templates/samples/templates/sample-form.jsp(38,75) The attribute prefix cmsfn does not correspond to any imported tag library

Haven't been able to trace what the problem is yet, might be another occurrence of http://jira.codehaus.org/browse/MJSPC-4

Upgraded to maven-jspc-plugin 2.0-alpha-1 but did not help.



 Comments   
Comment by Magnolia International [ 16/Oct/07 ]

Vaguely similar to MAGNOLIA-1419

Comment by Magnolia International [ 16/Oct/07 ]

Also we should try and get the JSPs to be compiler with tomcat 5.0.28 instead of 5.5.15

Comment by Magnolia International [ 17/Oct/07 ]

We actually just realized the taglibs aren't "processed" either: here's an excerpt of one of the generated classes:
out.write("<cms:mainBar paragraph=\"samplesPageProperties\"/>");
So the issue is probably not directly related to using a function taglib.

This was also the case with 1.4.7.

Comment by Magnolia International [ 09/Sep/08 ]

Version 2.0-alpha-2 of the jspc maven plugin released recently doesn't help in this regard.

For the record, I had to add these dependencies to the plugin for it to work at all, for some reason:

          <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-log4j12</artifactId>
            <version>1.4.1</version>
          </dependency>

          <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>jcl104-over-slf4j</artifactId>
            <version>1.4.1</version>
          </dependency>
Comment by Magnolia International [ 09/Sep/08 ]

links to actual issues:
http://jira.codehaus.org/browse/MJSPC-4
http://jira.codehaus.org/browse/MJSPC-21
http://jira.codehaus.org/browse/MNG-2720
http://jira.codehaus.org/browse/MJSPC-31
https://issues.apache.org/bugzilla/show_bug.cgi?id=37084#c5

Comment by Magnolia International [ 09/Sep/08 ]

2.0-alpha-3 will hopefully fix this if they apply the patch from Kevin Christmas on MJSPC-4. Changed plugin version in magnolia-parent-pom-6-SNAPSHOT.

Comment by Magnolia International [ 07/Jan/09 ]

Well, 2.0-alpha-3 doesn't fix the issue. Now it throws an exception, which at least makes things obvious.

1612 [main] INFO org.apache.jasper.JspC - Built File: /mgnl-files/templates/samples/paragraphs/controls-jsp-sample.jsp
1628 [main] WARN org.apache.jasper.compiler.TldLocationsCache - Internal Error: File /WEB-INF/web.xml not found
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] File "/mgnl-files/templates/samples/paragraphs/cms-taglib" not found
[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.jasper.JasperException: File "/mgnl-files/templates/samples/paragraphs/cms-taglib" not found
	at org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:51)
Comment by Magnolia International [ 29/May/09 ]

jspc issue still not fixed

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:30:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.