[MAGNOLIA-1887] searchResultSnippet should replace <br> tags with white space instead of removing them completly Created: 26/Nov/07  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia
Component/s: None
Affects Version/s: 3.0.5
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Will Scheidegger Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Any


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The stripHtmlTags() method of the SearchResultSnippetTag class should not simply strip all HTML tags. Line breaks should be replaced by white space.This can be simply done by searching & replacing line break tags first, then stripping all remaining HTML tags:

protected String stripHtmlTags(String resultString) {
resultString = resultString.replaceAll("
<br>", " ");
resultString = resultString.replaceAll("
<br/>", " ");
resultString = resultString.replaceAll("
<br />", " ");
resultString = resultString.replaceAll("
<BR>", " ");
resultString = resultString.replaceAll("
<BR/>", " ");
resultString = resultString.replaceAll("
<BR />", " ");
return resultString.replaceAll("\\<(.?\\s)*
>", StringUtils.EMPTY); //$NON-NLS-1$
}

I'm sure one could also achive the same with a single regex statement.



 Comments   
Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 03:31:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.