[MAGNOLIA-1902] output buffer is not flushed after JSP include in JSPTemplateRenderer Created: 28/Nov/07  Updated: 23/Jan/13  Resolved: 29/Nov/07

Status: Closed
Project: Magnolia
Component/s: templating
Affects Version/s: 3.5 RC1
Fix Version/s: 3.5 RC2

Type: Bug Priority: Blocker
Reporter: Sameer Charles Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
is superseded by MAGNOLIA-2129 Cache : RenderingFilter should not fl... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The best possible solution would be to have a filter (lets say CommitFilter) which does response.flushBuffer() and stops the chain.

  • This will allow us dynamically to stop the chain anytime and commit the response, otherwise filter itself has to know that its the last filer.

As a result you can have incomplete page rendering.

  • Tested/proven under Liferay container


 Comments   
Comment by Magnolia International [ 28/Nov/07 ]

We won't add a new filter in RC2.
Would just calling flush on the response in JSPTemplateRenderer work ?

Comment by Philipp Bracher [ 29/Nov/07 ]

I added the flushing in RenderingFilter.

Notes:

  • CommitFilter was not added to avoid changes from rc1 to rc2
  • CommitFilter would not allow later redirects after a template filled the buffer, so for that a different solution/filter must be found
  • Tomcat does flush the buffer by default, but I'm not sure if this is part of the spec or not
Generated at Mon Feb 12 03:31:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.