[MAGNOLIA-1916] NPE when updating from 3.0.5 due to missing cache voters Created: 03/Dec/07 Updated: 23/Jan/13 Resolved: 05/Dec/07 |
|
| Status: | Closed |
| Project: | Magnolia |
| Component/s: | None |
| Affects Version/s: | 3.5 RC2 |
| Fix Version/s: | 3.5 RC3 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Vivian Steller | Assignee: | Vivian Steller |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
When updating from 3.0.5 right after installing and hitting the "startup magnolia" button the NPE attached occurs. This, is bug was accidentally introduced with r13327. |
| Comments |
| Comment by Fabrizio Giustina [ 03/Dec/07 ] |
|
This is related to After reviewing how updates are handled now I am always more in favour of keeping the startupTasks in the module version handler (call them "checkThatEverythingIsOkWithTheCurrentVersion" if startupTasks doesn't sound well in a module version handler). The approach of doing an update/fix the configuration when there is something wrong is easier and more robust than using versions in order to control which task should be run. For example I had to spend a day trying to update a system which was already running a magnolia 3.1 milestone build in order to successfully update to 3.5-rc2 For example I had to deal with errors like: for me doing this kind of approach vs a version based approach for critical tasks is:
The conclusion is that I will be happy to put back the creation of cache voters were it was previously, in startup tasks. |
| Comment by Vivian Steller [ 05/Dec/07 ] |
|
So, finally, I think (at least for the 3.5 final version) we should definitely revert back to the solution with the startup tasks. In general the So, can you roll back the changes to the startup solution then? Thank you, Fabrizio! |
| Comment by Vivian Steller [ 05/Dec/07 ] |
|
okay, I'll quickly do it... |
| Comment by Vivian Steller [ 05/Dec/07 ] |
|
solved: reverted back to startup task solution. svn revision for that change is r13392. |