[MAGNOLIA-1968] MgnlUserManager.getAllUsers doesn't return any users Created: 19/Dec/07  Updated: 11/Aug/11  Resolved: 11/Aug/11

Status: Closed
Project: Magnolia
Component/s: security
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Capitaine Harold Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: toreview
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File patch.txt    
Issue Links:
duplicate
duplicates MAGNOLIA-1947 MgnlUserManager does not take realm i... Closed
is duplicated by MAGNOLIA-2496 getAllUsers method from MgnlUserManag... Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

I think that the function MgnlUserManager.getAllUsers was created before realm and hasn't been refreshed since this time.
See the the patch in attachment for the new method that returns all users from all realms.

HTH



 Comments   
Comment by Magnolia International [ 19/Dec/07 ]

This is duplicate of MAGNOLIA-1947. Thanks for the patch though, we'll look into it.

(although I'm curious how you built/tested it, since your usage of tabs should have made the build fail )

Comment by Magnolia International [ 19/Dec/07 ]

After quickly looking into the patch, I dont think it's valid: it's collecting all users of all realms, not those in the realms of the UserManager.
What should happen is it should collect all users of its own realm, and the DelegatingUserManager should collect them from all registered UserManager instances.

Comment by Capitaine Harold [ 19/Dec/07 ]

Ok I will correct it because I didn't know what to do.
I will get the realm from the private variable realmName, is it the way to do it or do you have another point of view to get the realm name?

Comment by Magnolia International [ 19/Dec/07 ]

getRealmName()

Comment by Yuanhua Qu [ 06/Feb/08 ]

Do you have a code fix on this one yet? We also use MgnlUserManager.getAllUsers to list all the users in our system (3.0.5 version) and works fine. But It returned empty list when we tested with 3.5.4 version. I'd appreciate if you could point out the change that can make it work again.

Comment by Magnolia International [ 07/Feb/08 ]

Qu, Harold's patch is working but not correct imo, see my comment. In the meantime, it could work for you. Will add it as a candidate to 3.5.5

Comment by Yuanhua Qu [ 07/Feb/08 ]

It does works for us. Thanks.

Comment by Philipp Bärfuss [ 17/Feb/11 ]

Scheduled it for 4.4.3.

Comment by Ondrej Chytil [ 11/Aug/11 ]

Fixed with MAGNOLIA-1947.

Generated at Mon Feb 12 03:32:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.