[MAGNOLIA-1978] uuidLinkType does not function properly - returns no results Created: 21/Dec/07  Updated: 23/Jan/13  Resolved: 11/Jan/08

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 3.5.2
Fix Version/s: 3.5.3

Type: Bug Priority: Major
Reporter: Ryan Gardner Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 1h
Time Spent: Not Specified
Original Estimate: 1h

Attachments: Text File fix_Outjava.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

In Out.java, there is an error where the uuidLink is pulled from the cms:out attribute "uuid" instead of from the value of the node. The handle one was set up correctly - but the others were not.

To test this out - you can set up a simple paragraph that has this in its content:

<strong>absolute:</strong><cms:out nodeDataName="northeast" uuidToLink="absolute"/><br/> <!-- should output an absolute link -->
<strong>relative:</strong><cms:out nodeDataName="northeast" uuidToLink="relative"/><br/> <!-- should output a relative link -->
<strong>handle:</strong><cms:out nodeDataName="northeast" uuidToLink="handle"/><br/> <!-- should output a handle -->
<strong>none:</strong><cms:out nodeDataName="northeast" uuidToLink="none"/><br/> <!-- should output the uuid -->

and make a dialog where you have "northeast" defined by controlType "uuidLink"

The above page will render with blanks for the values in the current code, and that's because of an error in the code. The fix is to have it use the value of the node as the UUID to build the link - not the uuid attribute of the tag.

I have attached a patch that applies this fix. It works properly on my system. In the patch, I also added more documentation to the Out.java code to help explain the existing logic that is in the code.

With this fix, the above output works the way it is expected.



 Comments   
Comment by Ryan Gardner [ 21/Dec/07 ]

assigning it to the taglibs component

Comment by Philipp Bracher [ 11/Jan/08 ]

Many Thanks!

Generated at Mon Feb 12 03:32:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.