[MAGNOLIA-1984] Mappings for wrapped servlets are not strict enough Created: 03/Jan/08  Updated: 23/Jan/13  Resolved: 11/Jan/08

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.5.2
Fix Version/s: 3.5.3

Type: Bug Priority: Critical
Reporter: Magnolia International Assignee: Vivian Steller
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: Not Specified
Original Estimate: 0d

Attachments: File mylyn-context.zip    
Issue Links:
relation
is related to MAGNOLIA-1662 Wrap modules' servlets in Filters Closed
supersession
is superseded by MAGNOLIA-2115 The ServletDispatchingFilter doesn't ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

For instance if the mapping is /dms/, the filter is *not bypassed for /foobar/dms/blah.html ...
and the result is a 404 for URLs like http://localhost:8080/magnoliaAuthor/modules/dms/example.html



 Comments   
Comment by Magnolia International [ 03/Jan/08 ]

fixed for simple cases like /dms/*, but mappings like *.foo completely fail.
(and their pathinfo is also wrong)

Comment by Magnolia International [ 03/Jan/08 ]

in fact, the SimpleUrlPattern used there isn't following the servlet mapping spec much. Maybe we should reimplement it there, of find some library that does it:

"SRV.11.2 Specification of Mappings
In the web application deployment descriptor, the following syntax is used to define
mappings:
• A string beginning with a '/' character and ending with a '/*' postfix is used
for path mapping.
• A string beginning with a '*.' prefix is used as an extension mapping.
• A string containing only the '/' character indicates the "default" servlet of the
application. In this case the servlet path is the request URI minus the context
path and the path info is null.
•All other strings are used for exact matches only."

Comment by Vivian Steller [ 11/Jan/08 ]

fixed on svn with r13989.

Note that a NotImplementedException will be thrown when using extension mappings for servlets.

Generated at Mon Feb 12 03:32:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.