[MAGNOLIA-1994] Internal virtual uri broken ? Created: 09/Jan/08  Updated: 23/Jan/13  Resolved: 31/Jan/08

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.5.2
Fix Version/s: 3.5.3, 3.5.4

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Vivian Steller
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: Not Specified
Original Estimate: 0d

Attachments: Text File MAGNOLIA-1994.patch    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Haven't had the chance to try and reproduce on a clean system, but it seems that plain virtual uri's just don't work anymore. forward:/foo/bar and redirect:/foo/bar work, external redirects too, but mapping "/" to "/foo" or "/foo.html" results in a 404 eventhough the "foo" page exists in the root.



 Comments   
Comment by Magnolia International [ 09/Jan/08 ]

the following patch fixed it for me - please review (and cleanup the commented out code )

Comment by Vivian Steller [ 11/Jan/08 ]

applied patch. works fine. so, fixed on svn with r13987. Thanks Greg!

Comment by Fabrizio Giustina [ 15/Jan/08 ]

emh, after we changed the magnolia filter to also handle forward request the "old way" of doing internal forwards by resetting the internal request uri should not be needed anymore.
We should change also internal forward in order to make them normal forward... this is what the previous change tried to do.

Probably the error was doing:
StringUtils.substringAfter(targetUri, "forward:");
also if the original path had no "forward:" prefix... we should try this and remove the aggregationState.setCurrentURI(targetUri) hack

Comment by Philipp Bracher [ 31/Jan/08 ]

The current implementation seams to be fine. Ether you want to re-execute the chain (so you use the forward prefix) or you just want to change the current uri (omit the prefix)

Generated at Mon Feb 12 03:32:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.