[MAGNOLIA-2010] WebContextImpl.include() should use pageContext if available Created: 18/Jan/08  Updated: 23/Jan/13  Resolved: 31/Jan/08

Status: Closed
Project: Magnolia
Component/s: core, templating
Affects Version/s: 3.5.3
Fix Version/s: 3.5.4

Type: Bug Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLSD-167 2 column paragraph doesn't set column... Closed
relation
is related to MAGNOLIA-2395 fix hack related to MAGNOLIA-2186 and... Closed
is related to MAGNOLIA-3338 Context is not updated on include req... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Included JSPs don't always get the expected request, for instance when passing parameters around.
-> the WebContextImpl.include() method uses the original http request to do the include: it should use the pageContext when it's available (it's set by the ParagraphRenderingFacade)
-> the ParagraphRenderingFacade should unset the pageContext when it's done, to make sure the pageContext does not get reused by mistake on further includes.



 Comments   
Comment by Magnolia International [ 18/Jan/08 ]

commited fix to svn

Comment by Philipp Bracher [ 31/Jan/08 ]

no issues till now so I resolve for the 3.5.4 release

Generated at Mon Feb 12 03:32:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.