[MAGNOLIA-2015] VirtualURIFilter: forward to JSP pages does not work anymore Created: 21/Jan/08  Updated: 23/Jan/13  Resolved: 31/Jan/08

Status: Closed
Project: Magnolia
Component/s: core
Affects Version/s: 3.5.3
Fix Version/s: 3.5.4

Type: Bug Priority: Major
Reporter: Ralf Hirning Assignee: Philipp Bärfuss
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLETK-27 Multi site support and virtualURIMapp... Closed
dependency
depends upon MAGNOLIA-2027 filters: improve forward and virtualU... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

With M 3.0.5 you could specify in the VirtualURIFilter a JSP to render a page. Now this leads to 404 Errors.

If you add

// set this attribute to avoid a second dispatching of the filters
request.setAttribute(DontDispatchOnForwardAttributeVoter.DONT_DISPATCH_ON_FORWARD_ATTRIBUTE, Boolean.TRUE);

before calling forward(request, response), like it is done in JspTemplateRenderer, it works.



 Comments   
Comment by Philipp Bracher [ 25/Jan/08 ]

So we have to add an other kind of keyword then.

Something like: direct-forward could be used

Comment by Philipp Bracher [ 25/Jan/08 ]

An other solution would be to support virtual uri implementations which do the forward inside the method. They could return a 'send' value to tell the uri filter to stop the chain.

Comment by Ralf Hirning [ 25/Jan/08 ]

This would not help as the current implementation already stops the filter chain.

Comment by Philipp Bracher [ 25/Jan/08 ]

I meant that you do the forward inside the VirtualURIMapping.mapURI() method. To step the chain you would then have to tell the filter that by returning a 'stop' value.

So the mapping would do the forward but not the filter. The filters job would only be stop execution (without forwarding)

But I guess the former proposal of using direct-forward keyword would be better

Comment by Philipp Bracher [ 31/Jan/08 ]

Have done a quick fix. A better fix like MAGNOLIA-2027 do need more changes and can not be done in a bugfix release

Generated at Mon Feb 12 03:32:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.