[MAGNOLIA-205] missing release() on cms tags Created: 23/Nov/04  Updated: 26/Jul/05  Resolved: 26/Jul/05

Status: Closed
Project: Magnolia
Component/s: taglibs
Affects Version/s: 2.0 Final
Fix Version/s: 2.1 Final

Type: Bug Priority: Minor
Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

custom jsp tags in magnolia don't correctly implement the release() method as requested by jsp specs. All the tag attributes should be reset to their initial status in the release method.
If you have many similar tags in the same page this could lead to strange behaviours in containers which use tag pooling. Seems to be not so evident in Tomcat but it will surely cause problems in containers which apply a more "aggressive" tag pooling like for example jetty.



 Comments   
Comment by Sameer Charles [ 23/Nov/04 ]

and we need to cleanup these tags. getting messy here

Comment by Fabrizio Giustina [ 07/May/05 ]

fixed in utility taglib (apart from a couple of deprecated tags) and for most of the tags in the main taglib.

Comment by Fabrizio Giustina [ 22/Jul/05 ]

all the tags have been fixed and reviewed. Closing!

Comment by Boris Kraft [ 26/Jul/05 ]

reassigned to RC3

Generated at Mon Feb 12 03:15:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.